Skip to content

Simplify live reload SSE endpoint after Puma bug is fixed #950

@ayushn21

Description

@ayushn21

While pairing with @ioquatix, we looked at the live reload code in Bridgetown to try and make it work with both Falcon and Puma.

Currently we're spawning a background thread to hold the connection, which is at best a hack, and at worst, wrong. We need to do this because Ctrl+C doesn't kill Puma without it. This turns out to be a bug in Puma itself. We've filed an issue here: puma/puma#3569.

After this is fixed, we should be able to remove the background thread from the SSE endpoint without any issues.

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions