-
Notifications
You must be signed in to change notification settings - Fork 2
Integrate old changes #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
NadavToledo1
wants to merge
61
commits into
brightdata:main
Choose a base branch
from
NadavToledo1:integrate-old-changes
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add query validation in search()
Add URL validation in crawl()
Add depth parameter validation in crawl()
Add snapshot_id format validation in download_snapshot()
Add security warning in connect_browser() docstring
Better error message for missing LLM key in extract()
change the constant DEFAULT_TIMEOUT to 30
Add clear validation with helpful error message pointing to env variable
Change client.download_snapshot("") to have placeholder comment
update and improve client.search_GPT
update search_gpt example
fix spelling errors
add class TestClientSearchGPT
add snapshot_id validation
fix imports
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update introduces a major restructuring of the repository along with the required implementation changes.