Drop obsolete scheme input from example workflows (#403)#413
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
brightdigit/swift-build@v1 no longer needs an explicit scheme — the MistKit and MistDemo workflows already omit it. Remove the now-obsolete `scheme:` input from the BushelCloud and CelestraCloud workflows to match. These are subrepo workflows; propagate upstream via `git subrepo push` after review. (ConfigKeyKit is excluded — that subrepo is being removed entirely in a separate PR.) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
1e6aa8f to
cd460d6
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v1.0.0-beta.3 #413 +/- ##
=================================================
+ Coverage 71.82% 71.90% +0.07%
=================================================
Files 168 156 -12
Lines 3844 3698 -146
=================================================
- Hits 2761 2659 -102
+ Misses 1083 1039 -44
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
ReviewReviewed the diff ( Summary: Minimal, mechanical change — removes the now-unnecessary Code quality / correctness: No issues. The diff only removes a line in each of the 4 steps; surrounding Minor nit (non-blocking): In both files, Performance / security: N/A — CI-config-only change, no runtime code, secrets, or permissions touched. Test coverage: N/A (workflow YAML). The PR description already notes the 7 edited files parse and the Overall: safe, well-scoped cleanup. ✅ |
brightdigit/swift-build@v1no longer needs an explicitscheme— the MistKit and MistDemo workflows already omit it. Removes the now-obsoletescheme:input from the BushelCloud and CelestraCloud workflows to match.These are subrepo workflows; changes will be propagated upstream via
git subrepo pushafter approval.ConfigKeyKit excluded: that subrepo is being removed entirely in #417, so its workflow is not modified here.
Closes #403.