Skip to content

Drop obsolete scheme input from example workflows (#403)#413

Merged
leogdion merged 1 commit into
v1.0.0-beta.3from
chore/remove-scheme-workflows
Jun 30, 2026
Merged

Drop obsolete scheme input from example workflows (#403)#413
leogdion merged 1 commit into
v1.0.0-beta.3from
chore/remove-scheme-workflows

Conversation

@leogdion

@leogdion leogdion commented Jun 30, 2026

Copy link
Copy Markdown
Member

brightdigit/swift-build@v1 no longer needs an explicit scheme — the MistKit and MistDemo workflows already omit it. Removes the now-obsolete scheme: input from the BushelCloud and CelestraCloud workflows to match.

These are subrepo workflows; changes will be propagated upstream via git subrepo push after approval.

ConfigKeyKit excluded: that subrepo is being removed entirely in #417, so its workflow is not modified here.

⚠️ The issue body was empty — please confirm this is the intended target set.

Closes #403.

@coderabbitai

coderabbitai Bot commented Jun 30, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 33bfcb76-f598-401b-8097-6d7fdd00ed23

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/remove-scheme-workflows

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

brightdigit/swift-build@v1 no longer needs an explicit scheme — the
MistKit and MistDemo workflows already omit it. Remove the now-obsolete
`scheme:` input from the BushelCloud and CelestraCloud workflows to match.

These are subrepo workflows; propagate upstream via `git subrepo push`
after review. (ConfigKeyKit is excluded — that subrepo is being removed
entirely in a separate PR.)

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@leogdion leogdion force-pushed the chore/remove-scheme-workflows branch from 1e6aa8f to cd460d6 Compare June 30, 2026 16:24
@leogdion leogdion changed the title Drop obsolete scheme input from example/package workflows (#403) Drop obsolete scheme input from example workflows (#403) Jun 30, 2026
@codecov

codecov Bot commented Jun 30, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.90%. Comparing base (9894d48) to head (cd460d6).
⚠️ Report is 2 commits behind head on v1.0.0-beta.3.

Additional details and impacted files
@@                Coverage Diff                @@
##           v1.0.0-beta.3     #413      +/-   ##
=================================================
+ Coverage          71.82%   71.90%   +0.07%     
=================================================
  Files                168      156      -12     
  Lines               3844     3698     -146     
=================================================
- Hits                2761     2659     -102     
+ Misses              1083     1039      -44     
Flag Coverage Δ
mistdemo-spm-macos ?
mistdemo-swift-6.2-jammy ?
mistdemo-swift-6.2-noble ?
mistdemo-swift-6.3-jammy ?
mistdemo-swift-6.3-noble ?
spm 71.87% <ø> (+0.35%) ⬆️
swift-6.1-jammy 71.59% <ø> (-0.14%) ⬇️
swift-6.1-noble 71.59% <ø> (-0.28%) ⬇️
swift-6.2-jammy 71.57% <ø> (-0.09%) ⬇️
swift-6.2-noble 71.76% <ø> (+0.16%) ⬆️
swift-6.3-jammy 71.57% <ø> (+0.02%) ⬆️
swift-6.3-noble 71.62% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@leogdion leogdion marked this pull request as ready for review June 30, 2026 23:49
@leogdion leogdion merged commit 4395549 into v1.0.0-beta.3 Jun 30, 2026
45 of 47 checks passed
@claude

claude Bot commented Jun 30, 2026

Copy link
Copy Markdown

Review

Reviewed the diff (Examples/BushelCloud/.github/workflows/BushelCloud.yml, Examples/CelestraCloud/.github/workflows/CelestraCloud.yml).

Summary: Minimal, mechanical change — removes the now-unnecessary scheme: ${{ env.PACKAGE_NAME }}-Package input from 4 brightdigit/swift-build@v1 steps (2 per file). Confirmed no scheme: input remains anywhere in the repo's workflows (including MistKit's and MistDemo's, which the PR description says already omit it), so this brings BushelCloud/CelestraCloud in line with the rest of the fleet.

Code quality / correctness: No issues. The diff only removes a line in each of the 4 steps; surrounding with: blocks are untouched and still well-formed YAML.

Minor nit (non-blocking): In both files, PACKAGE_NAME (declared in the top-level env: block, e.g. BushelCloud.yml:23) was only ever referenced by the now-removed scheme: lines. After this change it's an unused env var in both workflows. Worth a quick follow-up to drop it (or fold into #417's ConfigKeyKit cleanup) so it doesn't linger as dead config — not worth blocking this PR on.

Performance / security: N/A — CI-config-only change, no runtime code, secrets, or permissions touched.

Test coverage: N/A (workflow YAML). The PR description already notes the 7 edited files parse and the mistdemo build succeeds; since these are git-subrepo mirrors (BushelCloud/CelestraCloud .gitrepo files confirm method = merge), the real validation will be the next CI run after git subrepo push, as the PR body already flags.

Overall: safe, well-scoped cleanup. ✅

@leogdion leogdion deleted the chore/remove-scheme-workflows branch July 1, 2026 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant