Overhaul CI matrix, add Windows/Android builds, clean up tooling scaffolding#79
Overhaul CI matrix, add Windows/Android builds, clean up tooling scaffolding#79
Conversation
|
Important Review skippedToo many files! This PR contains 160 files, which is 10 over the limit of 150. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (160)
You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #79 +/- ##
==========================================
+ Coverage 65.39% 65.66% +0.26%
==========================================
Files 31 32 +1
Lines 526 533 +7
==========================================
+ Hits 344 350 +6
- Misses 182 183 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
PR Review: 2.0.0 alpha.2Thanks for the alpha.2 update. This is a well-scoped PR with clear intent. Here is my review: Summary of Changes
Positive AspectsvisionOS support ( WASM/cross-platform improvements: Wrapping Test refactoring: Splitting Issues and Concerns1. Redundant In #if canImport(Dispatch)
// test body
#else
Issue.record("This test requires Dispatch and should be disabled on WASM")
#endifSince the entire suite is already annotated with 2. The class retains 3. Cascading Wrapping the Minor Nits
Test CoverageThe new test files ( VerdictNo blocking issues. The two items most worth a second look before merging are (1) the redundant |
No description provided.