-
Notifications
You must be signed in to change notification settings - Fork 3
feat: PE-968: Create SQLlite brightscript example for Barrows #85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Add an example app that combines BrightScript and JavaScript to handle SQLite database operations
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Adds a sample BrightScript/JavaScript application demonstrating SQLite database operations via a message port.
- Introduces
index.jsfor JS-side messageport handling and issuing SQL commands. - Implements
autorun.brswith a BrightScript event loop and helper functions for creating, querying, and deleting records. - Updates Husky hooks by adding a shared script and adjusting the commit message hook.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| examples/bs-sqlite-db-example/index.js | JS messageport setup and sequential SQLite command flow |
| examples/bs-sqlite-db-example/autorun.brs | BrightScript event loop and SQLite helper functions |
| .husky/prepare-commit-msg | Sources common hook logic and invokes commitizen hook |
| .husky/common.sh | Adds command_exists helper and Windows/Git Bash workaround |
Comments suppressed due to low confidence (2)
examples/bs-sqlite-db-example/autorun.brs:7
- The variable 'm' is used without initialization; initialize 'm' (for example via
m = CreateObject("roAssociativeArray")) before assigning properties to it.
m.nodejs = CreateObject("roNodeJs", "SD:/index.js", { message_port: port })
examples/bs-sqlite-db-example/autorun.brs:50
- The variable 'cmd' is undefined here; use the correct variable (e.g.,
eventData.message.command) or pass the SQL string into the print statement.
print "Failed to insert record: "; cmd
jdmedlin1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
lherlein
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
📝 Description
Add an example app that combines BrightScript and JavaScript to handle SQLite database operations
Issue: PE-968
✔️ Dev Complete Checklist