fix: Correct time zone deficiencies OS-20888#124
Merged
Conversation
caneraltinbasak
approved these changes
Mar 13, 2026
caneraltinbasak
left a comment
caneraltinbasak
left a comment
There was a problem hiding this comment.
Australian time zones used be a constant problem in the past on Brightsign. Seems like tradition continues here.
t-bashir-bs
added a commit
that referenced
this pull request
Mar 25, 2026
t-bashir-bs
added a commit
that referenced
this pull request
May 13, 2026
t-bashir-bs
added a commit
that referenced
this pull request
May 15, 2026
t-bashir-bs
added a commit
that referenced
this pull request
May 15, 2026
t-bashir-bs
added a commit
that referenced
this pull request
May 15, 2026
t-bashir-bs
added a commit
that referenced
this pull request
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
This patch makes the same changes we have made to our system icu in OS-16298.
QtWebEngine uses system ICU and picks up the fix that way. Flag use_system_icu has been removed since chromium 87 and its not recommended to use system ICU due to potential compatibility issues. Therefore we are patching the Chromium ICU with the same change.
Checklist
npm testpassesRelease Notes
Notes: