fix: Add missing implementation for rotating popups in html widgets #72
Merged
Conversation
t-bashir-bs
changed the title
t-bashir-bs
force-pushed
the
28-x-y-bs-fix-rotated-popups
branch
from
60b47bb to
762fe2f
Compare
t-bashir-bs
requested review from
andy-brightsign,
caneraltinbasak and
jdye-bs
andy-brightsign
approved these changes
Nov 20, 2024
andy-brightsign
left a comment
andy-brightsign
left a comment
There was a problem hiding this comment.
I am new to this code, but it makes sense to me,
t-bashir-bs
added a commit
that referenced
this pull request
May 23, 2025
* OS-17652: Add support for window rotation * Mention windowTransform webpreference is for Linux * Add window rotation test case --------- Signed-off-by: Tariq Bashir <120014322+t-bashir-bs@users.noreply.github.com> test: Improve html window rotation tests (#67) Improve html window rotation tests fix: Add missing implementation for rotating popups in html widgets (#72) * Fix rotated popup windows * Add extra test for popup window rotation Cherry picked from: 0947088: feat: Add support for window rotation OS-17652 (#65) 5d09884: test: Improve html window rotation tests (#67) 96a6d5d: fix: Add missing implementation for rotating popups in html widgets (#72)
t-bashir-bs
added a commit
that referenced
this pull request
Jul 2, 2025
* OS-17652: Add support for window rotation * Mention windowTransform webpreference is for Linux * Add window rotation test case --------- Signed-off-by: Tariq Bashir <120014322+t-bashir-bs@users.noreply.github.com> test: Improve html window rotation tests (#67) Improve html window rotation tests fix: Add missing implementation for rotating popups in html widgets (#72) * Fix rotated popup windows * Add extra test for popup window rotation Cherry picked from: 0947088: feat: Add support for window rotation OS-17652 (#65) 5d09884: test: Improve html window rotation tests (#67) 96a6d5d: fix: Add missing implementation for rotating popups in html widgets (#72)
t-bashir-bs
added a commit
that referenced
this pull request
Apr 30, 2026
* OS-17652: Add support for window rotation * Mention windowTransform webpreference is for Linux * Add window rotation test case --------- Signed-off-by: Tariq Bashir <120014322+t-bashir-bs@users.noreply.github.com> test: Improve html window rotation tests (#67) Improve html window rotation tests fix: Add missing implementation for rotating popups in html widgets (#72) * Fix rotated popup windows * Add extra test for popup window rotation Cherry picked from: 0947088: feat: Add support for window rotation OS-17652 (#65) 5d09884: test: Improve html window rotation tests (#67) 96a6d5d: fix: Add missing implementation for rotating popups in html widgets (#72)
t-bashir-bs
added a commit
that referenced
this pull request
May 6, 2026
* OS-17652: Add support for window rotation * Mention windowTransform webpreference is for Linux * Add window rotation test case --------- Signed-off-by: Tariq Bashir <120014322+t-bashir-bs@users.noreply.github.com> test: Improve html window rotation tests (#67) Improve html window rotation tests fix: Add missing implementation for rotating popups in html widgets (#72) * Fix rotated popup windows * Add extra test for popup window rotation Cherry picked from: 0947088: feat: Add support for window rotation OS-17652 (#65) 5d09884: test: Improve html window rotation tests (#67) 96a6d5d: fix: Add missing implementation for rotating popups in html widgets (#72)
t-bashir-bs
added a commit
that referenced
this pull request
May 20, 2026
* OS-17652: Add support for window rotation * Mention windowTransform webpreference is for Linux * Add window rotation test case --------- Signed-off-by: Tariq Bashir <120014322+t-bashir-bs@users.noreply.github.com> test: Improve html window rotation tests (#67) Improve html window rotation tests fix: Add missing implementation for rotating popups in html widgets (#72) * Fix rotated popup windows * Add extra test for popup window rotation Cherry picked from: 0947088: feat: Add support for window rotation OS-17652 (#65) 5d09884: test: Improve html window rotation tests (#67) 96a6d5d: fix: Add missing implementation for rotating popups in html widgets (#72)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Html widget rotation support was added, but changes to allow popup rotation were not done. Popups are used for html form elements such as select and date picker elements. This change adds the missing functionality for popup rotation as well as adding to the existing rotation test cases to check popups as well.
The improved test coverage highlighted a bug that when an html widget rectangle is resized the transforms are not updated, and so a fix for this has also been added.
Checklist
npm testpassesRelease Notes
Notes: