Skip to content

Conversation

@philrz
Copy link
Contributor

@philrz philrz commented Nov 21, 2025

tl;dr

This converts blockquotes in the docs to mdbook admonitions.

Details

For the most part I did just conversion and resisted the urge to do major corrections to the content, but did make a few adjustments if it seemed silly to convert content we've already agreed should go/change. I've made inline comments to call attention to these.

The way we were using blockquotes before, we had a loose convention of putting the text in italics for extra emphasis, but since the admonitions have the icon, colored vertical bar, and colored background, that seemed like enough emphasis that while touching all these I standardized on dropping the italics.

TODO items called out in the docs have been left as blockquotes.

Comment on lines -83 to -88
> The [Zui](https://zui.brimdata.io/) desktop application automatically starts a
> SuperDB database service when it launches. Therefore if you are using Zui you can
> skip the first set of commands shown above. The pool can be created from Zui
> by clicking **+**, selecting **New Pool**, then entering `ts` for the
> [pool key](../../command/db.md#sort-key).
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We reached consensus that we'd drop mention of the desktop app in the docs for now, so I removed this text rather than convert to an admonition.

the super ID.

> _Change the first N values to type values instead of nulls?_
> _TODO: Change the first N values to type values instead of nulls?_
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The closing ? led me to assume this should be framed as a TODO.

the tag of the union type indicating which column the value falls within.

> Change code to conform to columns array instead of record{c0,c1,...}
> _TODO: Change code to conform to columns array instead of record{c0,c1,...}_
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this was a statement about a likely code change I converted it to a TODO.

Comment on lines -40 to -48
### Copy to CLI

If you want to transfer a working playground query to your shell, just
click on CLI tab and you will see text suitable for pasting into a
`bash`, `zsh`, etc.

> Note that there is no special quoting for the shell so you may run
> into problems if you mix single and double quotes in your query.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dropped this text since we removed the functionality in #6378.

@philrz philrz self-assigned this Nov 21, 2025
@philrz philrz requested a review from a team November 21, 2025 18:30
@philrz philrz marked this pull request as ready for review November 21, 2025 18:30
@philrz philrz merged commit a86832e into main Nov 21, 2025
4 checks passed
@philrz philrz deleted the book-admonitions branch November 21, 2025 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants