join(): Fix inconsistency between sam and vam variants#6491
Merged
Conversation
nwt
approved these changes
Jan 6, 2026
This commit changes the sam version of join() to return a null string when a null string array is encountered. Also moves the tests to the standard locations and makes the testing more complete.
mattnibs
force-pushed
the
join-func-redux
branch
from
e0f3f67 to
4cc2ce6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit changes the sam version of join() to return a null string when a null string array is encountered. Also moves the tests to the standard locations and makes the testing more complete.