Closed
Conversation
mattnibs
force-pushed
the
vam-condition-deunion
branch
3 times, most recently
from
277cca0 to
624eb81
Compare
This commit fixes an issue in vam conditionals where the values in the then or else expressions where getting deunioned. This changes the approach by using expr.BoolMask to determine the routing of returned values. Fixes #6907
mattnibs
force-pushed
the
vam-condition-deunion
branch
from
624eb81 to
2c8031d
Compare
nwt
reviewed
May 7, 2026
| } | ||
|
|
||
| func (c *conditional) Eval(this vector.Any) vector.Any { | ||
| return vector.Apply(true, c.eval, c.predicate.Eval(this), this) |
Member
There was a problem hiding this comment.
All we need to do is use vector.NoRip here.
return vector.Apply(true, c.eval, c.predicate.Eval(this), &vector.NoRip{Any: this})
Collaborator
Author
There was a problem hiding this comment.
Didn't know about this, let's do it this way
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit fixes an issue in vam conditionals where the values in the then or else expressions where getting deunioned. This changes the approach by using expr.BoolMask to determine the routing of returned values.
Fixes #6907