Gen2024 removing int8 casts#4
Merged
brittonsmith merged 3 commits intoOct 22, 2024
Merged
Conversation
…tes1d_g from integer (presumably it defaults to integer*4) to integer*8. - This removed the need for every int8 cast during calls to interpolate_2D_g (within lookup_cool_rates1d_g) - these 2 are local variables
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is VERY simple PR that replaces the gfortran-extension routine,
int8(arg), with the equivalent standard routineint(arg,8). This was creating problems for some of the scripts that I had written to help transcribe from fortranInside of
lookup_cool_rates1d_g, I was able to eliminate a number of casts. Previously, we repeatedly cast 2 local variablesd_Nandd_Size. Now we just declare the locald_Nandd_Sizevariables to have the correct type.I locally tested and confirmed that all tests pass after these changes.
Maybe we should make the gen2024 branch a branch on the grackle repository so that we can properly run CI on PRs?
Note
The
test_models.pysuite of tests seem flaky. Usually they pass, but a handful of them fail (usually, they'll pass after I relaunch them). This is an issue I observed in the gen2024 branch even without these changes. Thus, I'm extremely confident that these changes NOT are causing that issue. (I suspect we are allocating memory somewhere and not properly initializing it -- hopefully this becomes more apparent as we go along)