transcribe calc_tdust_3d#40
Closed
mabruzzo wants to merge 729 commits into
Closed
Conversation
This was referenced Mar 3, 2025
Optimize circleci workflows
remove 2 unneeded files
…sting-without-editable-install Support running subset of pygrackle test without a an editable install
remove a line that was made obsolete by PR grackle-project#224
…tweak cython does not need to be a runtime-dependency
…nstruction-tweaks Pygrackle test instruction tweaks
fix a typo in a CMake variable name
Tweak cython-handling in build-system
…Warnings Enable Compiler Warnings in a CI job
…lding_length_fix H2 self shielding length scale factor fix
Superficial Website Documentation Tweaks
[newchem-cpp] Minor model test refactor and adding model comparison option
…e/internal_types_updates [newchem-cpp] internal scratch-buffer interface update
…e/Implement-SpLUT-with-XMacros [newchem-cpp] Refactor such that SpLUT is implemented with XMacros
…e/SpeciesLUTFieldAdaptor [newchem-cpp] Introduce `SpeciesLutFieldAdaptor`
The *Great Renaming:* `gracklepy` edition
…e/initial-step_rate_newton_raphson [newchem-cpp] initial transcription of `step_rate_newton_raphson`
…phson-cleanup-1of2
…phson-cleanup-1of2
…' into gen2024transcribe/lookup_cool_rates0d
…scribe/lookup_cool_rates0d_cleanup
…2024transcribe/calc_temp_cloudy_g I needed to introduce the bugfix from PR grackle-project#367.
…cribe/scale_fields_table
…cribe/interpolate-wrappers
…nscribe/calc_tdust_3d
Author
|
superseded by grackle-project#385 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This builds directly on top of PR #37
This PR transcribes
calc_tdust_3dfrom Fortran to C++. This was the last of the top-level Fortran routines to be translated.Figuring out how a bunch of the variables got used (so we could logically aggregate the variables) was fairly tedious. In fact the immediate impetus for making this PR was my review of #39, where I wanted to give recommendation on how to organize the same variables. The whole process was so involved, I wanted to put together this PR before I lost my train of thought (and so I could make more concrete suggestions).1
A little bit of cleanup is performed in the followup PR, #41.
I have manually confirmed that all tests successfully pass.
NOTE: I have not run the OpenMP tests. I'm pretty confident that the transcribed code is all valid. But, since Gen broke OpenMP support, I have not been tempted to test it yet. The fact that I have been developing on MacOS complicates this to some degree2
Footnotes
In particular, understanding the purpose and use of the
alSiM,alFeM, ...,alH2Oicefamily of variables were especially annoying. These were named in a particularly confusing way that made it impossible to understand how they related to thekpSiM,kpFeM, ...,kpH2Oicefamily of variables without fully digging in. (I suspect my frustration comes through, to some degree in some of the code comments) ↩I think it should definitely be possible using a compiler other than the built-in apple-clang compilers. But, I haven't gotten a chance to dig into this. I suspect this will easier to deal with once we have removed the last of the Fortran code that references OpenMP. ↩