Cell fields support callbacks #27
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 1486049023
💛 - Coveralls |
Pull Request Test Coverage Report for Build 1433252876
💛 - Coveralls |
brmighell
changed the title
artoonie
approved these changes
Nov 10, 2021
Collaborator
artoonie
left a comment
artoonie
left a comment
There was a problem hiding this comment.
Nice work! A few minor comments throughout.
Kha6Shafiei
approved these changes
Nov 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need to figure out how we're going to talk to the client! Offer a specific menu of supported strings to reference functions? Have the functions themselves get passed?