Require -o argument in design.py #20
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the `-o/--output-probes` argument was optional. This could be desired if the goal was only to determine the number of probes: even if the probe set is designed in order to compute this number, one could simply leave out `-o` to ignore the probe set. But this might be confusing, since a user could easily run `design.py` to design a probe set, and find out after it runs that the probe set was not output. It could also be wasteful because `design.py` is sometimes computationally expensive to run and a user could mistakenly leave out `-o`. To avoid these issues, this commit changes the output argument to be required. This also updates the README to account for `-o` now being required.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the
-o/--output-probesargument was optional. Thiscould be desired if the goal was only to determine the number
of probes: even if the probe set is designed in order to compute
this number, one could simply leave out
-oto ignore the probeset. But this might be confusing, since a user could easily
run
design.pyto design a probe set, and find out after it runsthat the probe set was not output. It could also be wasteful
because
design.pyis sometimes computationally expensive to runand a user could mistakenly leave out
-o.To avoid these issues, this commit changes the output argument
to be required.
This also updates the README to account for
-onow beingrequired.