Skip to content

Fix initial guess to be within bounds #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 25, 2022
Merged

Fix initial guess to be within bounds #43

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d357974
Fix initial guess to be within bounds
haydenm Feb 24, 2022
61e2656
Add recent Python versions to Travis CI testing
haydenm Feb 24, 2022
f368aec
Revert "Add recent Python versions to Travis CI testing"
haydenm Feb 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions catch/pool/param_search.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -710,11 +710,11 @@ def higher_dimensional_search(param_names, probe_counts, max_total_count,
# Setup the loss function, parameter bounds, and make an initial guess
loss_fn = _make_loss_fn(probe_counts, max_total_count, loss_coeffs,
dataset_weights, interp_fn_type='nd')
x0 = _make_initial_guess(probe_counts, None, num_params)
bounds = _make_param_bounds_nd(probe_counts)
x0 = _make_initial_guess(probe_counts, bounds, num_params)

# Find the optimal parameter values, interpolating probe counts
# for parameter values between what have been explicitly calculated
bounds = _make_param_bounds_nd(probe_counts)
x_sol = _optimize_loss(probe_counts, loss_fn, bounds, x0,
interp_fn_type='nd')

Expand Down