Added two annotations from v3 (absent from v2) to annotations hists c… #181
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@ch-kr super small one for you in the context of the annotations hists |
Contributor
Author
|
OK, actually running this over the v3, I found a couple of bugs that I squashed in this PR too! |
ch-kr
approved these changes
Mar 4, 2020
Contributor
ch-kr
left a comment
ch-kr
left a comment
There was a problem hiding this comment.
good catch! I actually just noticed the bin->bins bug when starting to review your other PR.
lfrancioli
force-pushed
the
var_hist_constants_add
branch
from
7121620 to
636f47c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…onstants