Remove Hail from install_requires #194
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkgoodrich
approved these changes
Mar 11, 2020
Contributor
jkgoodrich
left a comment
jkgoodrich
left a comment
There was a problem hiding this comment.
Looks good to me, thanks for putting that fix in!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because Hail is included in
install_requiresin setup.py,hailctl dataproc start a-cluster --packages gnomadalways installs the latest PyPI release of Hail. This overwrites any specific Hail version set by the --wheel argument.This removes Hail from
install_requiresbut leaves it in requirements.txt for Actions workflows and easy development setup.Resolves #192