Runtime variant QC fixes #238
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lfrancioli
approved these changes
Jul 15, 2020
Contributor
lfrancioli
left a comment
lfrancioli
left a comment
There was a problem hiding this comment.
Looks great! Thanks for addressing these!
ch-kr
approved these changes
Jul 15, 2020
Contributor
ch-kr
left a comment
ch-kr
left a comment
There was a problem hiding this comment.
looks good to me, just a small typo and suggested cond > if_else changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added changed that were needed in order to run the common code variant QC functions in the UKBB variant QC scripts