densify_sites update #279
Merged
densify_sites update #279
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkgoodrich
reviewed
Jan 11, 2021
Contributor
jkgoodrich
left a comment
jkgoodrich
left a comment
There was a problem hiding this comment.
Should we make it an option with default False incase using an older MT?
jkgoodrich
reviewed
Jan 11, 2021
Contributor
jkgoodrich
left a comment
jkgoodrich
left a comment
There was a problem hiding this comment.
Will both now be keyed by locus and alleles? will this always work?
last_END_positions_ht[sites_ht.key].last_END_position
what if sites_ht has different alleles but you still want to keep the locus?
Contributor
Author
|
that's a good point. what if I change |
Contributor
|
Yeah both would need to be re_keyed by locus, so I think that will work |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sparse MTs were previously only keyed by locus by default. They are now keyed by locus and alleles by default