Skip to content

Release 1.17.2 #252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Apr 25, 2022
Merged

Release 1.17.2 #252

merged 14 commits into from
Apr 25, 2022

Conversation

@jlchang
Copy link
Contributor

@jlchang jlchang commented Apr 25, 2022

No description provided.

devonbush and others added 14 commits April 19, 2022 15:11
@devonbush
Revert "setting value for __event_name"
ce9c630 
This reverts commit 4c8baf1.
@devonbush
Revert "improved variable scoping"
9d2a8f3 
This reverts commit 188218d.
@devonbush
Revert "minimizing change scope"
f2ab745 
This reverts commit 7b9f2ae.
@devonbush
Merge pull request #250 from broadinstitute/db-general-try-except
00a04a7 
Reverting general try-except (SCP-4279)
@jlchang
report dups instead of rejecting or falling back to gene_id
673dc43
@jlchang
clarify outfile name structure
a00b185
@jlchang
include additional cli params for annots
092811b
@jlchang
rename DE 'name' to 'cluster-name' for clarity
c135126
@jlchang
trivial check that input annot is type group
e6783d7
@jlchang
fix error msg typos
ec9eb68
@jlchang
add scope to outfile name; update tests
68c9a60
@jlchang
handle exception for failed DE: annot_label w/ single sample
a6f1c8a
@jlchang
address PR blockers/suggestions
e314978
@jlchang
Merge pull request #251 from broadinstitute/jlc_indicate_scope
3baaabf 
Enable DE on cluster annotations (SCP-4258)
eweitz
eweitz approved these changes Apr 25, 2022
View reviewed changes
Copy link
Member

@eweitz eweitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Enable DE for cluster annotations" (#251) strikes me as something "added", and thus worth 1.18.0!

@jlchang jlchang merged commit 1ac85e0 into master Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eweitz eweitz eweitz approved these changes

@bistline bistline Awaiting requested review from bistline

@ehanna4 ehanna4 Awaiting requested review from ehanna4

+1 more reviewer

@devonbush devonbush devonbush approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jlchang @eweitz @devonbush