Skip to content

refactor: add comments to generated Android code#137

Merged
brody2consult merged 15 commits intomasterfrom
add-comments-to-beginning-of-artifacts
Feb 18, 2021
Merged

refactor: add comments to generated Android code#137
brody2consult merged 15 commits intomasterfrom
add-comments-to-beginning-of-artifacts

Conversation

@brody2consult
Copy link
Owner

@brody2consult brody2consult commented Sep 18, 2019

in order to achieve the twin benefits of cleaner generated code and cleaner template source code

with some TODO items:

  • similar improvement for other artifacts - moved into separate PRs
  • check that generated modules with generated examples continue to build and run on Android & iOS

(for Android only, at this point)
@brody2consult brody2consult self-assigned this Sep 18, 2019
@brody2consult brody2consult changed the base branch from dev to master November 15, 2019 05:36
@brody2consult brody2consult changed the title [..] add comments to beginning of generated artifacts [TBD] add comments to beginning of generated artifacts - Android only - DRAFT WIP Feb 11, 2021
@brody2consult
Copy link
Owner Author

brody2consult commented Feb 11, 2021

Due to the number of changes over the past year I will likely may start again, in a new PR.

@brody2consult brody2consult changed the title [TBD] add comments to beginning of generated artifacts - Android only - DRAFT WIP [TBD ...] add comments to beginning of generated artifacts - Android only (...) Feb 11, 2021
@brody2consult brody2consult changed the title [TBD ...] add comments to beginning of generated artifacts - Android only (...) refactor: add comments to generated Android code Feb 12, 2021
@brody2consult brody2consult marked this pull request as ready for review February 18, 2021 04:32
@brody2consult brody2consult merged commit 310194c into master Feb 18, 2021
@brody2consult brody2consult deleted the add-comments-to-beginning-of-artifacts branch February 18, 2021 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant