quick fixes to handle CLI args errors#306
Merged
brody2consult merged 5 commits intomasterfrom Apr 5, 2020
Merged
Conversation
added 5 commits
April 5, 2020 17:40
demonstrates correct behavior in this case
reproduces issue 305 in lib/cli-command.js
which fails at this point, reproducing issue 119 (extra arguments silently ignored)
(issue 119)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
argsor emptyargsarray fromlib/cli-program.js- resolves Fix error message in case of missing name #305argsarray fromlib/cli-program.js- resolves extra arguments silently ignored #119with CLI lib tests in
tests/with-injection/cli/command/action-errorP.S. This was tested from the command line with the following commands:
./bin/cli.js --view./bin/cli.js name1 name2