Skip to content

fix minor indenting issue in ios pbxproj#345

Merged
brody2consult merged 2 commits intomasterfrom
fix-minor-indenting-issue-in-ios-pbxproj
May 7, 2020
Merged

fix minor indenting issue in ios pbxproj#345
brody2consult merged 2 commits intomasterfrom
fix-minor-indenting-issue-in-ios-pbxproj

Conversation

@brody2consult
Copy link
Owner

@brody2consult brody2consult commented May 7, 2020

  • fix indenting of "$(inherited)", line in generated iOS pbxproj
  • update affected test snapshots

discovered when using Xcode to add some dependencies for iOS while working on new SQLite plugin design for React Native, as discussed in brody2consult/ask-me-anything#3

In short, Xcode actually fixed this indentation issue when I added some other dependencies. I think it would be better to get this right the first time in the generated pbxproj.

TODO:

  • I would like to test this with generated example in my workarea before merging and releasing this update.

@brody2consult brody2consult added the bug Something isn't working label May 7, 2020
@brody2consult brody2consult self-assigned this May 7, 2020
@brody2consult brody2consult marked this pull request as ready for review May 7, 2020 18:45
@brody2consult brody2consult merged commit 14d3ae5 into master May 7, 2020
@brody2consult brody2consult deleted the fix-minor-indenting-issue-in-ios-pbxproj branch May 7, 2020 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant