Update UTF-8 conversion functions and header definitions.#77
Closed
diplfranzhoepfinger wants to merge 2 commits intobrofield:masterfrom
Closed
Update UTF-8 conversion functions and header definitions.#77diplfranzhoepfinger wants to merge 2 commits intobrofield:masterfrom
diplfranzhoepfinger wants to merge 2 commits intobrofield:masterfrom
Conversation
diplfranzhoepfinger
commented
Jul 29, 2024
diplfranzhoepfinger
commented
- Corrected typos in comments
- Changed typedef for UTF32 to use unsigned long
- Updated enum member descriptions for clarity
- Corrected typos in comments - Changed typedef for UTF32 to use unsigned long - Updated enum member descriptions for clarity
- Added comments to indicate fallthrough behavior in switch cases for UTF16toUTF8, isLegalUTF8, ConvertUTF8toUTF16, ConvertUTF32toUTF8, and ConvertUTF8toUTF32 functions.
Owner
|
Thank you for your suggestion. In general, I am not interested in patches to the ConvertUTF files as they aren't mine, but I can see that the copies of the files that I have are not the latest ones that were ever released. What I'll do instead of your PR is take the last version ever released by the UWG and replace the existing files with them. From what I can see, there are more changes in those files than what you have suggested in this PR. |
|
good idea |
brofield
added a commit
that referenced
this pull request
Dec 1, 2024
…UWG. This fixes a number of the spelling errors and other items that people over time have suggested fixes for. As suggested by #77
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.