copilot-adapter: expose outcome and reason as step outputs uniformly#141
Merged
Conversation
Align the copilot adapter's step outputs with the built-in shell adapter
shape: always populate the Outputs map on every result, regardless of
whether the step succeeded or failed. The shell adapter exposes
stdout/stderr/exit_code on success and failure paths alike; the copilot
adapter now exposes outcome and reason in the same fashion.
- outcome: mirrors the FSM transition outcome
- reason: the optional reason argument from submit_outcome, empty on
failure paths (reprompt exhaustion, permission denial,
max_turns) since the model did not supply one
Downstream steps can read steps.<name>.outcome and steps.<name>.reason
with a consistent schema regardless of how the step terminated.
brokenbot
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Outputson every result, success or failure.outcome(mirrors the FSM outcome) andreason(the model'ssubmit_outcomereason, empty on failure paths where the model did not supply one).reasonon the success path and leftOutputsnil on failures, giving downstream HCL an inconsistent schema. This change makessteps.<name>.outcomeandsteps.<name>.reasonreadable regardless of how the step ended.Test plan
go test ./cmd/criteria-adapter-copilot/ -count=1— full adapter suite passes.TestAwaitOutcome_OutcomeAndReasonInOutputsasserts both keys are present on success.TestAwaitOutcome_FailurePathPopulatesOutcomeOutputassertsoutcome="failure"andreason=""on the reprompt-exhaustion path.steps.<name>.outcomeandsteps.<name>.reasonafter a copilot step.