feat(status): Phase 2 — substrate status surface (0.5.0)#33
Merged
Conversation
Implements §6 Phase 2 of substrate completion spec (BRO-1154 under epic
BRO-1148). Gives the metrics pipeline shipped in v0.4.0 a readable face.
New `bin/bstack-status` dispatcher:
bstack status Colored text summary (8 sections)
bstack status --json Machine-readable JSON for CI / tooling
bstack status --setpoint S<n> Single-setpoint detail (text or --json)
bstack status --aggregate Phase 8 placeholder (exits 3)
--no-color Strip ANSI even on TTY
--no-collect Use stale cache without auto-running collect
The status command auto-runs `bstack metrics collect` if
~/.bstack/metrics/latest.json is missing or > 5 min old, so a fresh
install gets a populated panel without needing to call metrics first.
Sections rendered:
Plant derived from S11 + S12
Setpoints all setpoints in latest.json, classified vs alerts
Gates grep policy.yaml for G<n> + bypass audit (Phase 5)
Primitives grep CLAUDE.md table rows; fallback 20
Companion skills S10 value/target
Bridge S13 value/alert
RCS stability parse research/rcs/data/parameters.toml l3 lambda;
gracefully degrades when not configured
Last upgrade ~/.bstack/just-upgraded-from + last-update-check
Tests: 8 fixture-based covering text mode sections, --json shape,
--setpoint text+json modes, unknown-setpoint exit, --aggregate
placeholder, --no-color stripping, auto-collect behavior. Added to
vetted CI suite.
Bug fixed during smoke (caught + fixed pre-commit):
primitive_count + gate_count + gate_bypass used `grep -c ... || echo 0`
which double-emits "0\n0" on BSD/macOS grep (where `grep -c` exits 1
on zero matches AND outputs 0). Replaced with `|| true` + `tr -d`
whitespace. Regex also corrected from ^\| \*\*P[0-9]+\*\* (matches
no rows) to ^\| P[0-9]+ \| (matches actual table format).
Test bug fixed: tests/status-surface.test.sh had `set +e; ...; set -e`
which enabled -e for subsequent tests even though the script header
was `set -uo pipefail` (no -e). When test 7's grep -q returned 1 (no
ANSI found, as intended), set -e killed the script. Replaced with
explicit `|| true` + run-and-grab pattern.
Dispatcher updated: bstack status subcommand registered + new help
entry under Observability:.
SLO targets (introduced):
bstack status (cached): p50 < 500ms, p99 < 1s
bstack status (cold collect): p50 < 2.5s, p99 < 6s
bstack status --setpoint: p50 < 100ms, p99 < 300ms
Files:
- NEW bin/bstack-status
- NEW tests/status-surface.test.sh
- EDIT bin/bstack — register status subcommand + help section
- EDIT .github/workflows/ci.yml — add new test to VETTED allowlist
- EDIT VERSION → 0.5.0
- EDIT CHANGELOG.md — 0.5.0 entry
Linear: BRO-1154 (Phase 2, parent epic BRO-1148).
Spec: §6 Phase 2 of specs/2026-05-18-substrate-completion.md.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (6)
📝 WalkthroughWalkthroughThis PR introduces the Phase 2 substrate status surface feature: a new ChangesSubstrate Status Surface Feature
Sequence Diagram(s)sequenceDiagram
participant CLI as CLI Args
participant Parser as Flag Parser
participant Metrics as Metrics Refresh
participant Helpers as Helper Functions
participant Setpoint as Setpoint Mode
participant JSON as JSON Mode
participant Text as Text Summary
participant Exit as Exit Handler
CLI->>Parser: --json/--setpoint/text
Parser->>Metrics: Check latest.json
Metrics->>Helpers: Provide metrics data
alt --setpoint mode
Helpers->>Setpoint: Render per-setpoint details
Setpoint->>Exit: Return setpoint object or error
else --json mode
Helpers->>JSON: Compute summary fields
JSON->>JSON: Embed raw setpoints
JSON->>Exit: Output JSON object
else default text
Helpers->>Text: Analyze health metrics
Text->>Text: Render colored sections
Text->>Exit: Print summary report
end
Exit->>Exit: Exit based on blocking/informational count
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related issues
Poem
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Phase 2 of substrate completion (BRO-1154 under epic BRO-1148). Gives the metrics pipeline shipped in v0.4.0 a readable face.
New CLI
Auto-runs
bstack metrics collectif~/.bstack/metrics/latest.jsonis missing or > 5 min old. A fresh install gets a populated panel without calling metrics first.8 sections rendered
research/rcs/data/parameters.tomll3lambda; graceful degrade when absent~/.bstack/just-upgraded-from+ last-update-checkLive smoke against this workspace
Bugs caught + fixed pre-commit
grep -cdouble-emit on BSD/macOS.primitive_count + gate_count + gate_bypassusedgrep -c ... || echo 0which produces"0\n0"becausegrep -cexits 1 on zero matches AND outputs0. Replaced with|| true+tr -dwhitespace. Regex also corrected from^\| \*\*P[0-9]+\*\*(matches no rows) to^\| P[0-9]+ \|(matches actual table format).set -eleak.tests/status-surface.test.shhadset +e; ...; set -ewhich enabled-efor subsequent tests even though the script header wasset -uo pipefail(no -e). When test 7'sgrep -qreturned 1 (no ANSI found, as intended),set -ekilled the script. Replaced with explicit|| true+ run-and-grab pattern.Files
bin/bstack-status(~360 LOC)tests/status-surface.test.sh(8 fixture tests, all pass locally)bin/bstack— registerstatussubcommand + new help entry underObservability:.github/workflows/ci.yml— add new test to VETTED allowlistVERSION→0.5.0CHANGELOG.md— 0.5.0 entrySLO targets (introduced)
bstack status(cached metrics): p50 < 500ms, p99 < 1sbstack status(cold, auto-collects first): p50 < 2.5s, p99 < 6sbstack status --setpoint <S-id>: p50 < 100ms, p99 < 300msTest plan
Stack position
PR 6 of N in substrate completion. Depends on v0.4.0 (
bin/bstack-metrics). Spec: §6 Phase 2.🤖 Generated with Claude Code
Summary by CodeRabbit
New Features
statussubcommand providing workspace health summaries with text and JSON output formats.Tests
Documentation
Chores