feat(bstack): doctor + ROSTER updates for P12#5
Merged
Merged
Conversation
…line) Companion to broomva/workspace#44 (P12 governance) and the new broomva/persist skill repo. scripts/doctor.sh: - EXPECTED_COUNT: 11 → 12 - Count header regex: "Eleven/11" → "Twelve/12" - Primitive row check loop: 1..11 → 1..12 - P_NAMES[]: append "P12: Persistent Loop Discipline" - REFLEXIVE_PRIMS[]: P6 P7 P10 P11 → P6 P7 P10 P11 P12 (P12 is reasoning-enforced; doctor must verify its Reflexive Trigger Rule subsection is present in AGENTS.md) - SCRIPT_PATHS[]: append "skills/persist/scripts/persist.py" scripts/bootstrap.sh: - SKILL_REPOS: [persist]="broomva/persist" - ORDERED_SKILLS: insert persist after p9 (Foundation layer) - Banner count: 30 → 31 - Total reporting: 30 → 31 SKILL.md: - "Eleven irreducible primitives" → "Twelve" - "Twenty-eight curated skills" → "Twenty-nine" - P1–P11 → P1–P12 throughout - New P12 row in primitives quick-reference - Reflexive primitives list now includes P12 Smoke-tested locally: Against pre-merge local main: gaps for P10, P11, P12 (count, rows, sections, reflexive rules) Against post-merge worktree (broomva/workspace#44): 43/46 passes; 3 gaps are skill-script paths absent from the worktree (expected, same pattern as earlier doctor extensions) After workspace#44 merges and `npx skills update` propagates, doctor reports full primitive contract compliance on a real installed workspace. This completes the four-PR series: - broomva/bookkeeping#1 (P6 replay extension) — MERGED - broomva/persist initial commit (P12 substrate) — pushed to main - broomva/workspace#44 (P12 governance) — open - this PR (bstack doctor + ROSTER for P12) Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThe PR extends the skill framework from eleven to twelve primitives by introducing P12 (Persistent Loop Discipline), updates documentation and bootstrap configuration to reflect the new primitive, and adds validation logic to support the twelfth primitive in the doctor verification script. ChangesTwelve Primitives Framework Expansion
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion to broomva/workspace#44 (P12 governance) and broomva/persist initial commit. Extends doctor to verify P12 compliance, adds persist to ROSTER. Smoke-tested 43/46 against post-merge target.
Summary by CodeRabbit
Documentation
New Features