validate_milestones

githubtasksutils.go

@@ -4,6 +4,8 @@ import (
 	"fmt"
 
 	"golang.org/x/net/context"
+
+	pb "github.com/brotherlogic/githubtasks/proto"
 )
 
 func (s *Server) validateIntegrity(ctx context.Context) error {
@@ -13,6 +15,19 @@ func (s *Server) validateIntegrity(ctx context.Context) error {
 		if len(s.config.GetProjects()) == 0 {
 			s.RaiseIssue(ctx, "Task Issue", fmt.Sprintf("There are no projects listed"), false)
 		}
+
+		for _, project := range s.config.GetProjects() {
+			activeMilestone := false
+			for _, milestone := range project.GetMilestones() {
+				if milestone.GetState() == pb.Milestone_ACTIVE {
+					activeMilestone = true
+				}
+			}
+
+			if !activeMilestone {
+				s.RaiseIssue(ctx, "Task Issue", fmt.Sprintf("%v has no active milestones", project.GetName()), false)
+			}
+		}
 	}
 
 	return err

githubtasksutils_test.go

@@ -27,3 +27,33 @@ func TestEmptyConfig(t *testing.T) {
 		t.Errorf("Error in validation: %v", err)
 	}
 }
+
+func TestEmptyMilestones(t *testing.T) {
+	s := InitTestServer()
+
+	_, err := s.AddProject(context.Background(), &pb.AddProjectRequest{Add: &pb.Project{Name: "Hello", Milestones: []*pb.Milestone{&pb.Milestone{Name: "teting"}}}})
+	if err != nil {
+		t.Errorf("Error adding project: %v", err)
+	}
+
+	err = s.validateIntegrity(context.Background())
+
+	if err != nil {
+		t.Errorf("Error in validation: %v", err)
+	}
+}
+
+func TestActiveMilestone(t *testing.T) {
+	s := InitTestServer()
+
+	_, err := s.AddProject(context.Background(), &pb.AddProjectRequest{Add: &pb.Project{Name: "Hello", Milestones: []*pb.Milestone{&pb.Milestone{Name: "teting", State: pb.Milestone_ACTIVE}}}})
+	if err != nil {
+		t.Errorf("Error adding project: %v", err)
+	}
+
+	err = s.validateIntegrity(context.Background())
+
+	if err != nil {
+		t.Errorf("Error in validation: %v", err)
+	}
+}