Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 22 additions & 2 deletions githubtasksapi.go
Original file line number Diff line number Diff line change
@@ -1,8 +1,12 @@
package main

import "golang.org/x/net/context"
import (
"fmt"

import pb "github.com/brotherlogic/githubtasks/proto"
"golang.org/x/net/context"

pb "github.com/brotherlogic/githubtasks/proto"
)

// AddProject to the system
func (s *Server) AddProject(ctx context.Context, req *pb.AddProjectRequest) (*pb.AddProjectResponse, error) {
Expand All @@ -13,3 +17,19 @@ func (s *Server) AddProject(ctx context.Context, req *pb.AddProjectRequest) (*pb
}
return &pb.AddProjectResponse{}, err
}

// AddTask to the system
func (s *Server) AddTask(ctx context.Context, req *pb.AddTaskRequest) (*pb.AddTaskResponse, error) {
task := &pb.Task{Title: req.GetTitle(), Body: req.GetBody()}

for _, p := range s.config.GetProjects() {
for _, m := range p.GetMilestones() {
if m.GetName() == req.GetMilestoneName() && m.GetNumber() == req.GetMilestoneNumber() {
m.Tasks = append(m.Tasks, task)
return &pb.AddTaskResponse{Task: task}, nil
}
}
}

return nil, fmt.Errorf("Could not locate milestone %v/%v", req.GetMilestoneName(), req.GetMilestoneNumber())
}
17 changes: 16 additions & 1 deletion githubtasksapi_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,24 @@ func TestAddProject(t *testing.T) {
s := InitTestServer()

s.AddProject(context.Background(),
&pb.AddProjectRequest{Add: &pb.Project{Name: "test project"}})
&pb.AddProjectRequest{Add: &pb.Project{Name: "test project", Milestones: []*pb.Milestone{&pb.Milestone{Name: "Testing", Number: 1}}}})

if len(s.config.GetProjects()) != 1 {
t.Errorf("Project was not added")
}

_, err := s.AddTask(context.Background(),
&pb.AddTaskRequest{MilestoneName: "Testing", MilestoneNumber: 1, Title: "Add stuff", Body: "Do Stuff"})

if err != nil {
t.Errorf("Task add failed: %v", err)
}

_, err = s.AddTask(context.Background(),
&pb.AddTaskRequest{MilestoneName: "Testing_No", MilestoneNumber: 10, Title: "Add stuff", Body: "Do Stuff"})

if err == nil {
t.Errorf("Task add did not fail")
}

}
2 changes: 1 addition & 1 deletion proto/githubtasks.proto
Original file line number Diff line number Diff line change
Expand Up @@ -71,5 +71,5 @@ message AddTaskResponse {
service TasksService {
rpc AddProject(AddProjectRequest) returns (AddProjectResponse) {};
//rpc UpdateProject(UpdateProjectRequest) returns (UpdateProjectResponse) {};
//rpc AddTask(AddTaskRequest) returns (AddTaskResponse) {};
rpc AddTask(AddTaskRequest) returns (AddTaskResponse) {};
}