Skip to content

close_out_milestone #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brotherlogic merged 1 commit into from
Jan 19, 2020
Merged

close_out_milestone #51

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions githubtasksutils.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,7 @@ func (s *Server) processProjects(ctx context.Context) (time.Time, error) {
for _, project := range s.config.GetProjects() {
for _, milestone := range project.GetMilestones() {
if milestone.GetState() == pb.Milestone_ACTIVE {
countActive := 0

// Sort tasks by the UID
sort.SliceStable(milestone.GetTasks(), func(i, j int) bool {
Expand All @@ -94,10 +95,12 @@ func (s *Server) processProjects(ctx context.Context) (time.Time, error) {

for _, task := range milestone.GetTasks() {
if task.GetState() == pb.Task_ACTIVE {
countActive++
break
}

if task.GetState() == pb.Task_CREATED {
countActive++
num, err := s.github.createTask(ctx, task, milestone.GetGithubProject(), milestone.GetNumber())
s.Log(fmt.Sprintf("Added task %v -> %v,%v", task.GetTitle(), num, err))
if err != nil {
Expand All @@ -110,6 +113,12 @@ func (s *Server) processProjects(ctx context.Context) (time.Time, error) {
}
}

// If we've reached this point, we have no active taskss and no tasks that need creation
if len(milestone.GetTasks()) > 0 && countActive == 0 {
//Close out the milestone
milestone.State = pb.Milestone_COMPLETE
}

break
}

Expand Down
19 changes: 19 additions & 0 deletions githubtasksutils_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,6 +252,25 @@ func TestUpdateTasks(t *testing.T) {
t.Errorf("Bad update: %v", err)
}
}

func TestCompleteMilestone(t *testing.T) {
s := InitTestServer()
s.AddProject(context.Background(), &pb.AddProjectRequest{Add: &pb.Project{Name: "Hello", Milestones: []*pb.Milestone{&pb.Milestone{Name: "Testing", State: pb.Milestone_ACTIVE, Number: 1, Tasks: []*pb.Task{}}}}})
_, err := s.processProjects(context.Background())

_, err = s.AddTask(context.Background(),
&pb.AddTaskRequest{MilestoneName: "Testing", MilestoneNumber: 1, Title: "Add stuff", Body: "Do Stuff"})
_, err = s.processProjects(context.Background())
_, err = s.updateProjects(context.Background())

if err != nil {
t.Errorf("Bad update: %v", err)
}

// Completes the milestone
_, err = s.processProjects(context.Background())
}

func TestUpdateTasksWithFail(t *testing.T) {
s := InitTestServer()

Expand Down