feat(dv2): X5 Retail Hero loader (loader + mappers + schemas + test)#70
Merged
Conversation
…test Bring the X5 Retail Hero loader from feat/dv2-x5-real-data onto main as a self-contained, reviewable unit: the Click loader entrypoint, the record→Data-Vault mappers, the pydantic schemas, and the unit test. These files are X5-only (untouched on main since the merge-base), so the overlay is conflict-free. mappers.py reformatted to current ruff format. Verified no-Docker: pytest 3 passed; ruff check + format clean. Out of mypy scope (mypy packages=["src"]). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
DORA Metrics
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
First of a thematic series splitting the long-lived
feat/dv2-x5-real-databranch (X5 Retail Hero loader) into reviewable PRs ontomain. This PR carries the Python loader as a self-contained unit:warehouse/agentflow/dv2/loaders/x5_retail_hero/loader.py— Click entrypoint…/mappers.py— record → Data-Vault hub/sat/link mappers…/schemas.py— pydantic input/row schemastests/unit/test_x5_retail_hero_loader.py— unit testWhy split this way
The X5 branch had diverged (16 feature commits, behind
main). All 36 of its files are untouched onmainsince the merge-base, so each theme overlays without conflict. This series replaces a single 208-file mega-diff with reviewable per-theme PRs (loader → dbt models → infra/load-test → docs).Verification (no-Docker, Windows)
pytest tests/unit/test_x5_retail_hero_loader.py→ 3 passedruff check+ruff format --check→ clean (mappers.py reformatted to current ruff)mypy packages = ["src"]); nosrc/imports🤖 Generated with Claude Code