fix: drop 32-bit arch support#645
Merged
Merged
Conversation
Remove I686/x32 from the Arch enum and getArch() since no supported runner uses 32-bit x86, and 32-bit Linux ARM is not distributed by Firefox. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
ueokande
changed the title
There was a problem hiding this comment.
Pull request overview
This PR removes 32-bit architecture handling from the action’s platform detection and Firefox download URL generation, aligning supported platforms with available GitHub-hosted runner architectures and Firefox’s distributed builds.
Changes:
- Removed the
I686architecture constant and droppedx32mapping from runtime arch detection. - Removed 32-bit Linux/Windows download URL variants (
linux-i686,win32) from both archive and latest download URL builders. - Updated unit tests to remove 32-bit platform cases.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/platform.ts |
Removes 32-bit arch constant and eliminates x32 arch mapping so unsupported 32-bit runners fail fast. |
src/DownloadURL.ts |
Removes 32-bit Linux/Windows URL segments from both archive and “latest” URL generation. |
__test__/DownloadURL.test.ts |
Removes test cases that asserted 32-bit URL generation / unsupported-platform behavior for 32-bit variants. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove
I686/x32since no supported runner uses 32-bit Linux ARM is not distributed by Firefox.Supported platforms