fix(admin): open Chrome inspect page on Windows#374
Open
honor2030 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
chrome://inspect/#remote-debuggingthrough the Chrome executable on Windowswebbrowser.open()fallback for other casesTest Plan
uv run --with pytest --with pillow python -m pytest tests/unit/test_admin.py::test_open_chrome_inspect_uses_chrome_executable_on_windows -qfailed before the fix because Windows still calledwebbrowser.open()uv run --with pytest --with pillow python -m pytest tests/unit/test_admin.py::test_open_chrome_inspect_uses_chrome_executable_on_windows tests/unit/test_admin.py::test_open_chrome_inspect_falls_back_to_webbrowser_when_windows_chrome_missing -quv run --with pytest --with pillow python -m pytest tests/unit/test_admin.py -quv run --with pytest --with pillow python -m pytest tests/unit -quv run python -m compileall -q src testsgit diff --checkCloses #290
Summary by cubic
Fixes opening the Chrome inspect page on Windows by launching
chrome://inspect/#remote-debuggingvia the Chrome executable. Falls back towebbrowser.open()when Chrome isn’t found; macOS AppleScript path remains unchanged.chrome.exeinPROGRAMFILES,PROGRAMFILES(X86), orLOCALAPPDATAand launch the URL directly.webbrowser.open(url, new=2)if Chrome is missing or launch fails.Written for commit eaf6704. Summary will update on new commits. Review in cubic