fix: prevent false success reporting on unresolved blocking error#4324
Merged
Conversation
Contributor
There was a problem hiding this comment.
2 issues found across 5 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="browser_use/agent/system_prompts/system_prompt_anthropic_flash.md">
<violation number="1" location="browser_use/agent/system_prompts/system_prompt_anthropic_flash.md:96">
P2: This grounding check omits `browser_vision`, so screenshot-only facts can no longer be treated as verified even though the prompt defines screenshots as the ground truth.</violation>
</file>
<file name="browser_use/agent/system_prompts/system_prompt.md">
<violation number="1" location="browser_use/agent/system_prompts/system_prompt.md:148">
P2: This wording forbids grounded derived results like counts, so tasks that require counting or simple computation can be incorrectly reported as `not found` or unsuccessful.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
…o add-better-data-grounding
Agent Task Evaluation Results: 2/2 (100%)View detailed results
Check the evaluate-tasks job for detailed task execution logs. |
Contributor
There was a problem hiding this comment.
1 issue found across 3 files (changes from recent commits).
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="browser_use/agent/system_prompts/system_prompt.md">
<violation number="1" location="browser_use/agent/system_prompts/system_prompt.md:148">
P2: Keep a verbatim requirement for direct fields; `observed` alone is loose enough to allow paraphrased names or normalized URLs back into `success=true` responses.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Prevents false success by adding a blocking‑error check and tightens data grounding to verbatim copy across all browser agent prompts. Still forbids fabricated data; derived values are allowed with screenshot-based verification. Also reverts
google-genaito1.60.0for stability.Bug Fixes
success=false. Temporary obstacles (CAPTCHA, popups) don’t count.browser_state, or screenshot — copy exactly; don’t paraphrase or normalize URLs. Derived values (counts/totals) from observed data are allowed. Never construct; say not found.already_collected/results file). Applied across all prompt variants.Dependencies
google-genaifrom1.65.0to1.60.0.Written for commit b43c7dd. Summary will update on new commits.