fix: use login shell for PATH configuration in install script#4457
Merged
Conversation
When the install script is executed via `curl ... | bash`, it always runs in a bash process, so $BASH_VERSION is always set regardless of the user's actual shell. This causes PATH to be written to ~/.bashrc even for zsh users, making the `browser-use` command unavailable. Use $SHELL (the user's login shell) instead of $BASH_VERSION/$ZSH_VERSION to detect the correct shell RC file. Fixes browser-use#4440
|
|
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
1 issue found across 1 file
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="browser_use/skill_cli/install.sh">
<violation number="1" location="browser_use/skill_cli/install.sh:458">
P2: Post-install source instructions are inconsistent with PATH file selection for non-bash/zsh shells.</violation>
</file>
Since this is your first cubic review, here's how it works:
- cubic automatically reviews your code and comments on bugs and improvements
- Teach cubic by replying to its comments. cubic learns from your replies and gets better over time
- Add one-off context when rerunning by tagging
@cubic-dev-aiwith guidance or docs links (includingllms.txt) - Ask questions if you need clarification on any suggestion
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
Ensure print_next_steps() falls back to .profile for non-bash/zsh shells, matching the behavior of configure_path().
laithrw
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
~/.bashrcinstead of~/.zshrcfor zsh users$SHELL(user's login shell) instead of$BASH_VERSION/$ZSH_VERSION(running shell) for shell detectioncurl ... | bash, the script always runs in bash, so$BASH_VERSIONis always set regardless of the user's actual shellChanges
configure_path(): Replace$BASH_VERSION/$ZSH_VERSIONcheck with$(basename "$SHELL")print_next_steps(): Same fix for the shell RC file displayed in completion messageThis could be considered as a follow-up improvement if the maintainers prefer.
Fixes #4440