fix: detect uv installed via curl script#4478
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
No issues found across 1 file
Since this is your first cubic review, here's how it works:
- cubic automatically reviews your code and comments on bugs and improvements
- Teach cubic by replying to its comments. cubic learns from your replies and gets better over time
- Add one-off context when rerunning by tagging
@cubic-dev-aiwith guidance or docs links (includingllms.txt) - Ask questions if you need clarification on any suggestion
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes bug where
browser-useCLI installation failed if the user had installed via curl and note Homebrew.install_uvcheckedcommand -v uvbefore adding~/.local/binto PATH. This worked for Homebrew but not for curl-based installs, because Homebrew installs to a directory already in PATH.Summary by cubic
Fixes
browser-useCLI installs failing whenuvwas installed via the curl script, and makes the installer script executable. We now add commonuvpaths to PATH before detection so it works for both curl and Homebrew installs.$HOME/.local/binand$HOME/.cargo/binto PATH beforecommand -v uv; drop the redundant export after install.browser_use/skill_cli/install.shas executable so it can run directly.Written for commit fae8036. Summary will update on new commits.