diag(TEMP): stderr trace through plugin shutdown + forceFlush#77
Merged
Conversation
rc2 still shows orphan turn parents in cloud V4 traces. The bcode log file has no shutdown-related entries because none of the relevant code paths log on success. Add stderr writes so v4-worker's bcode-output-<runId>.log artifact captures: - whether the shutdown branch in src/index.ts's top-level finally is reached at all - pluginShutdownHooks.size at invocation time (was rc2's fix actually populating the Set?) - whether bcode-laminar.shutdown was invoked + how many turn spans it ended - forceFlush start, completion, rejection, or timeout stderr is captured by the v4-worker harness; we'll diff against the current 'log just stops mid-bus-event' baseline to localize which step is failing. Once V4 verification is settled and the actual fix is identified, this stderr diagnostic block can be removed. TEMP - to be removed after verification.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Temporary diagnostic instrumentation to localize why the bcode-laminar turn parent span still isn't landing in cloud V4 traces after v0.1.8-rc1 and rc2.
rc2 trace5a5bfaf8-dfa6-9678-d497-f1ef6ac3fde4: stilltop_span_landed=False,total_cost=0, 1 orphan parent (00000000-0000-0000-454f-11815e103257) referenced by all session.llm children. Same shape as rc1.Addsprocess.stderr.writecalls in:``-src/index.tstop-level finally: log pluginShutdownHooks.size, per-hook invocation success, forceFlush start/done/timeout`- `bcode-laminar/src/plugin.ts` shutdown: log span count being ended, span.end() throws if any`stderr is captured by v4-worker into `bcode-output-.log` artifact. Will diff against the current 'log stops mid-stream' baseline to find which step is failing.`Once the actual fix is identified and verified, this diagnostic block must be removed before `v0.1.8` proper.Summary by cubic
Add temporary stderr diagnostics around plugin shutdown and OpenTelemetry forceFlush to trace why parent turn spans are missing in cloud V4. Logs are captured in v4-worker’s
bcode-output-<runId>.logand will be removed beforev0.1.8.packages/opencode/src/index.ts: log when shutdown runs, how many plugin hooks exist, per-hook success/failure, andforceFlushstart/done/reject/timeout (3s cap).packages/bcode-laminar/src/plugin.ts: log how many turn spans are ended, catch and logspan.end()errors, and mark shutdown complete.Written for commit ae8be3e. Summary will update on new commits. Review in cubic