cleanup: remove TEMP stderr diagnostics from rc3-rc5#81
Merged
Conversation
Remove the [bcode]/[bcode-laminar] stderr lines that helped localize the headless V4 shutdown hook bugs. The actual fixes (async shutdown hook, pending-flush tracking, drop of sdk.shutdown bus race, drop of broken trace.getTracerProvider().forceFlush fallback) stay. Verified rc6 on V4 staging: trace b2837d1e-... has the bcode-laminar turn span landed with all session.llm/ai.streamText.doStream/bash spans correctly parented. Multi-turn trace 4f53f62c-... (10 LLM rounds) also clean. Only remaining orphan is the v4.run cloud-control-plane span (separate known bug -- CP emits to wrong Laminar project).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the temp [bcode]/[bcode-laminar] stderr lines that helped localize the headless V4 shutdown hook bugs. The actual fixes stay: async shutdown hook, pendingFlushes tracking, drop of sdk.shutdown bus race, drop of broken trace.getTracerProvider().forceFlush fallback.
Verified rc6 on V4 staging: turn span lands, all child spans correctly parented. Trace shapes attached in EXCEPTIONS.md update.Net diff: -76 lines.Summary by cubic
Removed temporary stderr diagnostics from
bcode-laminarand theopencodeshutdown path, keeping the real fixes (async shutdown hook with pending flush tracking, removal of thesdk.shutdownrace, and dropping the brokentrace.getTracerProvider().forceFlushfallback). This cleans up logs without changing behavior; OTel draining remains intact and verified on rc6 staging.Written for commit 99bcd24. Summary will update on new commits. Review in cubic