Polish King of Life agency mini app#257
Merged
Merged
Conversation
| if (text.includes("github")) return [0.12, 0.13, 0.16]; | ||
| if (text.includes("reddit")) return [1.0, 0.32, 0.12]; | ||
| if (text.includes("product")) return [0.86, 0.26, 0.18]; | ||
| if (text.includes("x.com") || text === "x") return [0.04, 0.05, 0.06]; |
Contributor
There was a problem hiding this comment.
1 issue found across 9 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="agent/mini_app_static/tinder.js">
<violation number="1" location="agent/mini_app_static/tinder.js:251">
P2: Missing `webglcontextrestored` handler means the WebGL scene permanently stops after context loss (common on mobile). Add a listener that re-creates the WebGL state and resumes drawing.</violation>
</file>
Reply with feedback, questions, or to request a fix.
Fix all with cubic | Re-trigger cubic
| rafId = requestAnimationFrame(draw); | ||
| } | ||
|
|
||
| canvas.addEventListener("webglcontextlost", (event) => { |
Contributor
There was a problem hiding this comment.
P2: Missing webglcontextrestored handler means the WebGL scene permanently stops after context loss (common on mobile). Add a listener that re-creates the WebGL state and resumes drawing.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At agent/mini_app_static/tinder.js, line 251:
<comment>Missing `webglcontextrestored` handler means the WebGL scene permanently stops after context loss (common on mobile). Add a listener that re-creates the WebGL state and resumes drawing.</comment>
<file context>
@@ -138,6 +150,285 @@ function haptic(kind = "selection") {
+ rafId = requestAnimationFrame(draw);
+ }
+
+ canvas.addEventListener("webglcontextlost", (event) => {
+ event.preventDefault();
+ running = false;
</file context>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
Notes
Summary by cubic
Redesigned the King of Life mini app with WebGL motion, safer approvals, and a tighter mobile deck to make accepting useful cards faster. Added daily/streak stats and domain breakdowns to the game state, and polished the 10 concept routes with a lightweight 3D scene.
New Features
tinder(#kingScene) andconcepts(#conceptScene) tied to rank/progress; honors reduced motion and survives context loss._game_statenow returnsdaily,streak,boss, anddomains; tests cover new fields and ledger-driven points.Refactors
:test-token.concept_sync, and source‑based scene coloring.Written for commit e8f9aec. Summary will update on new commits. Review in cubic