fix: active page context #251
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
When a page closes (e.g., splash screen during auth),
get_active_page()still returns the closed page instead of switching to a remaining open page.What Changed
Added
_handle_page_close()incontext.pyto switch active page to a remaining open page when the current active page closes.Test Plan
Verified with multi-page script: open two pages, close active page, confirm
get_active_page()returns remaining open page. Existing unit tests pass.Summary by cubic
Fixes stale active page after a page closes. When the active page closes (e.g., splash during auth), we now switch to a remaining open page or clear the active page.
Written for commit a7cb745. Summary will update automatically on new commits.