-
Notifications
You must be signed in to change notification settings - Fork 1.3k
[chore]: fix e2e local tests in CI #1323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No issues found across 1 file
Greptile OverviewGreptile SummaryAdded required API keys to the Additionally added a conditional check to prevent this job from running on fork pull requests where these secrets would not be available:
This prevents fork contributors from seeing failures due to missing secrets they cannot access. Confidence Score: 5/5
Important Files ChangedFile Analysis
Sequence DiagramsequenceDiagram
participant GHA as GitHub Actions
participant Job as run-e2e-local-tests
participant Secrets as GitHub Secrets
participant Tests as E2E Test Suite
participant APIs as External APIs
GHA->>Job: Trigger job (on push or PR)
alt Fork PR (external repo)
Job->>Job: Check: head.repo != base.repo
Job-->>GHA: Skip (no access to secrets)
else Same repo PR or push
Job->>Job: Check: head.repo == base.repo
Job->>Secrets: Fetch OPENAI_API_KEY
Job->>Secrets: Fetch GOOGLE_GENERATIVE_AI_API_KEY
Job->>Secrets: Fetch BROWSERBASE_API_KEY
Job->>Secrets: Fetch BROWSERBASE_PROJECT_ID
Job->>Secrets: Fetch ANTHROPIC_API_KEY
Secrets-->>Job: Return all API keys
Job->>Job: Set environment variables
Job->>Tests: Run e2e:local tests
Tests->>APIs: Make API calls (using keys)
APIs-->>Tests: Return responses
Tests-->>Job: Test results
Job-->>GHA: Success/Failure
end
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 file reviewed, no comments
why
e2e:localtests now require LLM API keyse2e:localstep in CI, which causes them to failwhat changed
envin CISummary by cubic
Fixes failing e2e:local tests in CI by skipping forks and passing the required API keys to the job.
Why:
What:
Test Plan:
Written for commit 7eb1ed9. Summary will update automatically on new commits.