No longer using changesets for stagehand-server - manually bumping package.json version number #1470
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Contributor
Greptile SummaryThis PR migrates stagehand-server away from the changesets release system to manual version management. The server release logic has been extracted from the main
Confidence Score: 5/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant Dev as Developer
participant Git as Git/GitHub
participant MainWF as release.yml
participant ServerWF as stagehand-server-release.yml
rect rgb(200, 220, 255)
Note over Dev,ServerWF: SDK Release (existing flow)
Dev->>Git: Push changesets to main
Git->>MainWF: Trigger on push to main
MainWF->>MainWF: Create Release PR or Publish
MainWF->>Git: Publish SDK to npm
MainWF->>Git: Publish canary build
end
rect rgb(220, 255, 220)
Note over Dev,ServerWF: Server Release (NEW flow)
Dev->>Git: Bump version in packages/server/package.json
Git->>ServerWF: Trigger on path change
ServerWF->>ServerWF: Detect version bump
ServerWF->>ServerWF: Build binaries (6 platforms)
ServerWF->>Git: Create git tag
ServerWF->>Git: Publish GitHub Release w/ binaries
end
Note over MainWF,ServerWF: Workflows are now independent and parallel
|
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
1 issue found across 3 files
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name=".github/workflows/stagehand-server-release.yml">
<violation number="1" location=".github/workflows/stagehand-server-release.yml:9">
P2: Manual `workflow_dispatch` triggers will never create releases because `github.event.before` is only available for `push` events. When triggered manually, `BEFORE_SHA` will be empty, causing `before_version` to be empty, and the release condition `[ -n "${before_version}" ]` will always fail. Consider adding fallback logic for manual triggers, such as checking if the tag already exists or adding a workflow input to force release.</violation>
</file>
Reply to cubic to teach it or ask questions. Re-run a review with @cubic-dev-ai review this PR
| - main | ||
| paths: | ||
| - packages/server/package.json | ||
| workflow_dispatch: |
Contributor
There was a problem hiding this comment.
P2: Manual workflow_dispatch triggers will never create releases because github.event.before is only available for push events. When triggered manually, BEFORE_SHA will be empty, causing before_version to be empty, and the release condition [ -n "${before_version}" ] will always fail. Consider adding fallback logic for manual triggers, such as checking if the tag already exists or adding a workflow input to force release.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At .github/workflows/stagehand-server-release.yml, line 9:
<comment>Manual `workflow_dispatch` triggers will never create releases because `github.event.before` is only available for `push` events. When triggered manually, `BEFORE_SHA` will be empty, causing `before_version` to be empty, and the release condition `[ -n "${before_version}" ]` will always fail. Consider adding fallback logic for manual triggers, such as checking if the tag already exists or adding a workflow input to force release.</comment>
<file context>
@@ -0,0 +1,313 @@
+ - main
+ paths:
+ - packages/server/package.json
+ workflow_dispatch:
+
+permissions:
</file context>
✅ Addressed in 21f2cc3
…sion to the latest existing stagehand-server tag
seanmcguire12
approved these changes
Dec 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
why
Changesets requires waiting for release PRs and we want to push new stagehand-server versions more frequently
what changed
No longer using changesets - manually bumping package.json version number
test plan
Summary by cubic
Switched stagehand-server releases from Changesets to a dedicated workflow that publishes on manual version bumps. This speeds up releases and automates tagging, binaries, and GitHub Releases.
Refactors
Migration
Written for commit 21f2cc3. Summary will update automatically on new commits.