Skip to content

Conversation

@monadoid
Copy link
Contributor

@monadoid monadoid commented Dec 24, 2025

why

Getting CI pipeline working to build server binaries

what changed

Removed colons from fastify routes for windows compat, and updated so that we're no longer using deprecated macos version for runner.

test plan

See checkmarks in CI


Summary by cubic

Fixes CI builds for server SEA binaries by making route file paths Windows-compatible and updating macOS runner versions.

  • Bug Fixes

    • Renamed route directories from v1/sessions/:id/* to v1/sessions/_id/* and updated imports in server.ts and gen-openapi.ts to avoid colon issues on Windows.
  • Dependencies

    • GitHub Actions now uses macos-15 and macos-15-intel runners (replacing macos-latest and macos-13), and the build job name reflects binary_name.

Written for commit 526f95b. Summary will update automatically on new commits.

… that we're no longer using deprecated macos version for runner.
@changeset-bot
Copy link

changeset-bot bot commented Dec 24, 2025

⚠️ No Changeset found

Latest commit: 526f95b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 10 files

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Dec 24, 2025

Greptile Summary

This PR fixes Windows compatibility issues in the CI pipeline for building server binaries by renaming route directories from :id to _id (colons are not allowed in Windows file paths), and updates macOS runners from deprecated versions (macos-latest, macos-13) to macos-15 and macos-15-intel.

  • Renamed route directory from packages/server/src/routes/v1/sessions/:id/ to packages/server/src/routes/v1/sessions/_id/ for Windows file path compatibility
  • Updated import paths in server.ts and gen-openapi.ts to reflect the new directory name
  • Changed macOS CI runners: macos-latestmacos-15 (arm64), macos-13macos-15-intel (x64)
  • Improved CI job naming to use matrix.binary_name instead of matrix.os for clarity

Confidence Score: 5/5

  • This PR is safe to merge - it contains only file renames and CI configuration updates with no logic changes.
  • The changes are purely structural (directory renaming for Windows compatibility) and CI infrastructure updates (macOS runner versions). No business logic, API behavior, or code functionality is modified. All route files retain their correct URL patterns using :id parameter syntax.
  • No files require special attention.

Important Files Changed

Filename Overview
.github/workflows/stagehand-server-release.yml Updated macOS runner versions from deprecated runners (macos-latest, macos-13) to macos-15 and macos-15-intel; improved job naming to use binary_name instead of os.
packages/server/scripts/gen-openapi.ts Updated import paths from :id to _id directory for Windows file path compatibility.
packages/server/src/server.ts Updated import paths from :id to _id directory for Windows file path compatibility.

Sequence Diagram

sequenceDiagram
    participant CI as GitHub Actions CI
    participant Build as Build Process
    participant FS as File System
    
    Note over CI,FS: Directory Rename for Windows Compatibility
    
    CI->>Build: Trigger build on push to main
    Build->>FS: Access routes/v1/sessions/_id/
    Note right of FS: Previously :id (fails on Windows)
    FS-->>Build: Route files accessible
    Build->>CI: Build succeeds on all platforms
    
    Note over CI: macOS runners updated
    CI->>CI: macos-15 (arm64)
    CI->>CI: macos-15-intel (x64)
Loading

@monadoid monadoid merged commit 81434a7 into main Dec 24, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants