-
Notifications
You must be signed in to change notification settings - Fork 1.3k
add waitForTimeout to page #1481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 5a1c904 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No issues found across 3 files
Greptile SummaryAdded Confidence Score: 5/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant User
participant Page
participant Promise
participant setTimeout
User->>Page: waitForTimeout(ms)
Page->>Promise: new Promise((resolve) => ...)
Promise->>setTimeout: setTimeout(resolve, ms)
Note over setTimeout: Wait for ms milliseconds
setTimeout-->>Promise: resolve()
Promise-->>Page: Promise resolves
Page-->>User: void
|
why
waitForTimeout is a nice util function to have
what changed
added waitForTimeout to page class
test plan
wrote tests, tested locally
Summary by cubic
Added Page.waitForTimeout(ms) to pause execution for a set duration.
Written for commit 5a1c904. Summary will update automatically on new commits.