Fix SEA release workflow for Windows#1603
Conversation
|
Greptile OverviewGreptile SummaryThis PR fixes the Windows SEA release workflow by adding
Confidence Score: 5/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant GHA as GitHub Actions Runner
participant Bash as Bash Shell
participant PNPM as PNPM Store
participant ENV as $GITHUB_ENV
participant Cache as Actions Cache
Note over GHA: Start "Get pnpm store directory"
GHA->>Bash: Execute with shell: bash
Bash->>PNPM: pnpm store path --silent
PNPM-->>Bash: Return store path
Bash->>ENV: echo "STORE_PATH=..." >> $GITHUB_ENV
ENV-->>Bash: Variable written
Note over GHA: Step complete
Note over GHA: Start "Setup pnpm cache"
GHA->>ENV: Read $STORE_PATH
ENV-->>GHA: Return store path
GHA->>Cache: Setup cache with path
Cache-->>GHA: Cache configured
|
There was a problem hiding this comment.
1 issue found across 2 files (changes from recent commits).
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name=".github/workflows/stagehand-server-release.yml">
<violation number="1" location=".github/workflows/stagehand-server-release.yml:105">
P2: Fetching a specific tag will fail the step when the tag doesn’t exist yet, because `set -e` turns the missing ref into a hard error. That prevents creating new tags on first release.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
| git config user.email "41898282+github-actions[bot]@users.noreply.github.com" | ||
|
|
||
| git fetch --tags --force | ||
| git fetch --force origin "refs/tags/${TAG}:refs/tags/${TAG}" |
There was a problem hiding this comment.
P2: Fetching a specific tag will fail the step when the tag doesn’t exist yet, because set -e turns the missing ref into a hard error. That prevents creating new tags on first release.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At .github/workflows/stagehand-server-release.yml, line 105:
<comment>Fetching a specific tag will fail the step when the tag doesn’t exist yet, because `set -e` turns the missing ref into a hard error. That prevents creating new tags on first release.</comment>
<file context>
@@ -114,7 +102,7 @@ jobs:
git config user.email "41898282+github-actions[bot]@users.noreply.github.com"
- git fetch --tags --force
+ git fetch --force origin "refs/tags/${TAG}:refs/tags/${TAG}"
if git rev-parse -q --verify "refs/tags/${TAG}" >/dev/null; then
</file context>
| git fetch --force origin "refs/tags/${TAG}:refs/tags/${TAG}" | |
| git fetch --force origin "refs/tags/${TAG}:refs/tags/${TAG}" || true |
why
Windows defaults to powersehell
what changed
Add shell:bash for the STORE_PATH on all platforms
test plan
Summary by cubic
Use pnpm/action-setup and setup-node v6 with built-in pnpm caching, removing the manual pnpm store path and Corepack steps to fix Windows runners. Adjusted checkout depth/tag settings and tag fetching to restore SEA build and release workflows on Windows and keep them consistent across platforms.
Written for commit 19e52cc. Summary will update on new commits. Review in cubic