Skip to content

Fix SEA release workflow for Windows#1603

Merged
seanmcguire12 merged 2 commits intomainfrom
fix-sea-release-workflow
Jan 24, 2026
Merged

Fix SEA release workflow for Windows#1603
seanmcguire12 merged 2 commits intomainfrom
fix-sea-release-workflow

Conversation

@miguelg719
Copy link
Collaborator

@miguelg719 miguelg719 commented Jan 24, 2026

why

Windows defaults to powersehell

what changed

Add shell:bash for the STORE_PATH on all platforms

test plan


Summary by cubic

Use pnpm/action-setup and setup-node v6 with built-in pnpm caching, removing the manual pnpm store path and Corepack steps to fix Windows runners. Adjusted checkout depth/tag settings and tag fetching to restore SEA build and release workflows on Windows and keep them consistent across platforms.

Written for commit 19e52cc. Summary will update on new commits. Review in cubic

@changeset-bot
Copy link

changeset-bot bot commented Jan 24, 2026

⚠️ No Changeset found

Latest commit: 19e52cc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@miguelg719 miguelg719 marked this pull request as ready for review January 24, 2026 00:35
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Jan 24, 2026

Greptile Overview

Greptile Summary

This PR fixes the Windows SEA release workflow by adding shell: bash to the "Get pnpm store directory" step. Windows GitHub Actions runners default to PowerShell, which uses different syntax for writing to $GITHUB_ENV (requires >> redirection to work differently). By explicitly specifying bash, the workflow now correctly sets the STORE_PATH environment variable across all platforms.

  • Fixed environment variable setting on Windows runners by forcing bash shell usage
  • Ensures consistency across Linux, macOS, and Windows platforms

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk
  • Single-line change that explicitly specifies shell type for cross-platform compatibility. The fix is targeted, well-understood, and follows GitHub Actions best practices for handling platform differences.
  • No files require special attention

Important Files Changed

Filename Overview
.github/workflows/stagehand-server-sea-build.yml Added shell: bash to fix STORE_PATH environment variable writing on Windows runners

Sequence Diagram

sequenceDiagram
    participant GHA as GitHub Actions Runner
    participant Bash as Bash Shell
    participant PNPM as PNPM Store
    participant ENV as $GITHUB_ENV
    participant Cache as Actions Cache

    Note over GHA: Start "Get pnpm store directory"
    GHA->>Bash: Execute with shell: bash
    Bash->>PNPM: pnpm store path --silent
    PNPM-->>Bash: Return store path
    Bash->>ENV: echo "STORE_PATH=..." >> $GITHUB_ENV
    ENV-->>Bash: Variable written
    Note over GHA: Step complete
    
    Note over GHA: Start "Setup pnpm cache"
    GHA->>ENV: Read $STORE_PATH
    ENV-->>GHA: Return store path
    GHA->>Cache: Setup cache with path
    Cache-->>GHA: Cache configured
Loading

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No files reviewed, no comments

Edit Code Review Agent Settings | Greptile

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 2 files (changes from recent commits).

Prompt for AI agents (all issues)

Check if these issues are valid — if so, understand the root cause of each and fix them.


<file name=".github/workflows/stagehand-server-release.yml">

<violation number="1" location=".github/workflows/stagehand-server-release.yml:105">
P2: Fetching a specific tag will fail the step when the tag doesn’t exist yet, because `set -e` turns the missing ref into a hard error. That prevents creating new tags on first release.</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.

git config user.email "41898282+github-actions[bot]@users.noreply.github.com"

git fetch --tags --force
git fetch --force origin "refs/tags/${TAG}:refs/tags/${TAG}"
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot Jan 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2: Fetching a specific tag will fail the step when the tag doesn’t exist yet, because set -e turns the missing ref into a hard error. That prevents creating new tags on first release.

Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At .github/workflows/stagehand-server-release.yml, line 105:

<comment>Fetching a specific tag will fail the step when the tag doesn’t exist yet, because `set -e` turns the missing ref into a hard error. That prevents creating new tags on first release.</comment>

<file context>
@@ -114,7 +102,7 @@ jobs:
           git config user.email "41898282+github-actions[bot]@users.noreply.github.com"
 
-          git fetch --tags --force
+          git fetch --force origin "refs/tags/${TAG}:refs/tags/${TAG}"
 
           if git rev-parse -q --verify "refs/tags/${TAG}" >/dev/null; then
</file context>
Suggested change
git fetch --force origin "refs/tags/${TAG}:refs/tags/${TAG}"
git fetch --force origin "refs/tags/${TAG}:refs/tags/${TAG}" || true
Fix with Cubic

@seanmcguire12 seanmcguire12 merged commit e5009fc into main Jan 24, 2026
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants