[STG-1733] fix: use valid metadata key for browse-cli sessions#1911
Merged
[STG-1733] fix: use valid metadata key for browse-cli sessions#1911
Conversation
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: d2cade9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
There was a problem hiding this comment.
1 issue found across 1 file
Confidence score: 5/5
- This PR appears low risk to merge because the only noted item is a low-severity (3/10) request for additional regression-test coverage, not a reported functional break.
- The key follow-up is to add a regression test in
packages/cli/src/index.tsto lock in thebrowse_cliremote-session metadata behavior and protect API compatibility over time. - Pay close attention to
packages/cli/src/index.ts- ensure thebrowse_climetadata key behavior is explicitly covered by a regression test.
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="packages/cli/src/index.ts">
<violation number="1" location="packages/cli/src/index.ts:702">
P3: Add a regression test for the remote session creation metadata key (`browse_cli`) so this API-compatibility fix is enforced.
(Based on your team's feedback about adding unit tests for new behavior.) [FEEDBACK_USED]</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
Contributor
|
@derekmeegan can you add a patch changeset here so it causes a version bump? |
shrey150
approved these changes
Mar 29, 2026
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Kylejeong2
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
browse-climetadata key (with hyphen) is rejected by the Browserbase API as an invalid metadata key, causingenv remoteto fail with a400 Key is not a valid metadata key: browse-clierror.browse_cli(underscore) which is a valid metadata key format.Linear: https://linear.app/browserbase/issue/STG-1733/fix-use-valid-metadata-key-for-browse-cli-sessions
Test plan
browse-cli) returns 400 from Browserbase APIbrowse_cli) returns 201 and session creates successfully🤖 Generated with Claude Code