Skip to content

[STG-1733] fix: use valid metadata key for browse-cli sessions#1911

Merged
shrey150 merged 2 commits intomainfrom
derek/fix-browse-cli-metadata
Mar 31, 2026
Merged

[STG-1733] fix: use valid metadata key for browse-cli sessions#1911
shrey150 merged 2 commits intomainfrom
derek/fix-browse-cli-metadata

Conversation

@derekmeegan
Copy link
Copy Markdown
Contributor

@derekmeegan derekmeegan commented Mar 29, 2026

Summary

  • The browse-cli metadata key (with hyphen) is rejected by the Browserbase API as an invalid metadata key, causing env remote to fail with a 400 Key is not a valid metadata key: browse-cli error.
  • Changed the key to browse_cli (underscore) which is a valid metadata key format.

Linear: https://linear.app/browserbase/issue/STG-1733/fix-use-valid-metadata-key-for-browse-cli-sessions

Test plan

  • Verified old key (browse-cli) returns 400 from Browserbase API
  • Verified new key (browse_cli) returns 201 and session creates successfully

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Mar 29, 2026

🦋 Changeset detected

Latest commit: d2cade9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 1 file

Confidence score: 5/5

  • This PR appears low risk to merge because the only noted item is a low-severity (3/10) request for additional regression-test coverage, not a reported functional break.
  • The key follow-up is to add a regression test in packages/cli/src/index.ts to lock in the browse_cli remote-session metadata behavior and protect API compatibility over time.
  • Pay close attention to packages/cli/src/index.ts - ensure the browse_cli metadata key behavior is explicitly covered by a regression test.
Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="packages/cli/src/index.ts">

<violation number="1" location="packages/cli/src/index.ts:702">
P3: Add a regression test for the remote session creation metadata key (`browse_cli`) so this API-compatibility fix is enforced.

(Based on your team's feedback about adding unit tests for new behavior.) [FEEDBACK_USED]</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.

@shrey150
Copy link
Copy Markdown
Contributor

@derekmeegan can you add a patch changeset here so it causes a version bump?

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@shrey150 shrey150 changed the title fix: use valid metadata key for browse-cli sessions [STG-1733] fix: use valid metadata key for browse-cli sessions Mar 31, 2026
@shrey150 shrey150 merged commit 56d7b9f into main Mar 31, 2026
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants