Conversation
🦋 Changeset detectedLatest commit: ba08fd0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
pirate
approved these changes
Mar 31, 2026
Contributor
There was a problem hiding this comment.
No issues found across 2 files
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Architecture diagram
sequenceDiagram
participant Client
participant Wrapper as withErrorHandling
participant Handler as Operation Handler (act/extract/observe)
participant Stream as createStreamingResponse
Note over Client,Handler: Standard Request Flow
Client->>Wrapper: HTTP Request
Wrapper->>Handler: Execute operation logic
alt Operation Success
Handler-->>Wrapper: Result data
Wrapper-->>Client: 200 OK (Data)
else Operation Throws Non-AppError
Handler-->>Wrapper: Throw Error("Specific failure")
Wrapper->>Wrapper: CHANGED: Extract err.message
Wrapper-->>Client: 500 Internal Server Error (Message: "Specific failure")
end
Note over Client,Stream: Streaming Request Flow
Client->>Wrapper: HTTP Request (Streaming)
Wrapper->>Stream: Initialize stream
Stream->>Handler: Run async operation
alt Operation Fails during Stream
Handler-->>Stream: Throw Error("Connection timeout")
Stream->>Stream: CHANGED: Set clientMessage = handlerError.message
Stream-->>Client: Send event: { "type": "error", "error": "Connection timeout" }
end
pirate
approved these changes
Mar 31, 2026
seanmcguire12
approved these changes
Mar 31, 2026
pirate
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
Summary by cubic
Pass through underlying operation errors in
@browserbasehq/stagehand-server-v3so clients see real failure messages during streaming and top-level responses, and force flow logs on for easier debugging. Status codes stay the same, making local act/extract/observe 500s diagnosable.AppErrorcases; fall back to a default when not anError, preserving status codes.Variablesimport/cast to satisfy lint; no behavior change.Written for commit ba08fd0. Summary will update on new commits. Review in cubic