fix: resolve server release versions from remote tags#1940
Merged
Conversation
|
Contributor
There was a problem hiding this comment.
No issues found across 2 files
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Architecture diagram
sequenceDiagram
participant Runner as GHA Runner
participant Remote as Git Remote (Origin)
participant FS as Local Filesystem
participant Logic as Version Logic (Node.js)
Note over Runner,Logic: Release Version Resolution Flow
Runner->>Remote: NEW: git ls-remote --tags
Remote-->>Runner: Return all remote tags
Runner->>Logic: NEW: Parse and sort tags to find highest version
alt No remote tags found
Logic-->>Runner: NEW: Throw Error (Refuse bootstrap from 0.0.0)
else Tags found
Logic-->>Runner: Return latest_tag
end
Runner->>Remote: CHANGED: git fetch --force (specific latest_tag)
Runner->>FS: CHANGED: git diff --diff-filter=d (ignore deleted changesets)
FS-->>Runner: List of active changeset files
Runner->>Logic: Calculate new version based on changesets
Logic->>Logic: Compare calculated version vs highest remote
alt NEW: Version <= Remote Version
Logic-->>Runner: Throw Error (Does not advance)
else Happy Path: Version > Remote Version
Logic-->>Runner: Return validated new version
end
Note over Runner: Continue to Publish / Tag step
pirate
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve server-v3 and server-v4 release versions from remote tags, fail instead of bootstrapping from 0.0.0, and refuse to publish any version that does not advance the highest existing remote tag.
Summary by cubic
Resolve release versions for
@browserbasehq/stagehand-server-v3and@browserbasehq/stagehand-server-v4from remote Git tags and add guardrails to stop non-advancing or bootstrapped releases. Workflows fail if no remote release tag exists.git ls-remote --tags(no local tag reliance).0.0.0bootstrap).Written for commit 77c176c. Summary will update on new commits. Review in cubic