Conversation
jeremypress
reviewed
Nov 21, 2024
Contributor
jeremypress
left a comment
jeremypress
left a comment
There was a problem hiding this comment.
looks good, might make sense in the future to have "stable" models that we can pin in the LLM Providers file, then any thing we run could pull stable Anthropic, stable Open AI etc, and not have manually set model names
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
why
We want evals for OpenAI and Anthropic. This does that and adds tags for each model if we want to break down performance.
Also, OpenAIClient wasn't working as expected, for some reason LogLine was being imported from the wrong place. This must've gotten lost in a previous PR, and due to the typing hell we're in, it got lost along the way. This fixes that.
what changed
example.tsto work with OpenAI and Anthropictest plan
Braintrust run
Also ran
example.tswithmodelNameofgpt-4o,claude-3-5-sonnet-20241022, and empty and they all work