[chore]: rm deepmerge from peer deps#2124
Merged
Merged
Conversation
|
Contributor
There was a problem hiding this comment.
No issues found across 2 files
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Architecture diagram
sequenceDiagram
participant Consumer as Package Consumer
participant PackageJson as package.json (core)
participant NPM as npm Installer
participant InstallScript as Install Script
Note over Consumer,InstallScript: PR Impact: Removes deepmerge from peerDependencies
Consumer->>PackageJson: Reads peerDependencies
PackageJson-->>Consumer: List: patchright-core, playwright-core, puppeteer-core
Note over Consumer,PackageJson: deepmerge no longer declared as peer dep
Consumer->>NPM: npm install
NPM->>PackageJson: Parse peerDependencies
alt deepmerge NOT in peerDependencies
NPM->>NPM: Skip warning about missing peer dep
NPM-->>Consumer: Clean install, no extra peer dep conflict
else deepmerge installed as transitive dep (optional)
NPM->>NPM: No peer dep validation for deepmerge
NPM-->>Consumer: Install proceeds normally
end
Note over Consumer,NPM: Result: Simpler dependency tree, fewer warnings
Consumer->>InstallScript: run build/test
InstallScript-->>Consumer: No deepmerge-related resolution failures
miguelg719
approved these changes
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
why
what changed
deepmergefrom peer depsSummary by cubic
Removed unused peer dependency
deepmergefrompackages/core. This simplifies installs and removes unnecessary peer warnings.Written for commit 50652b8. Summary will update on new commits.