Skip to content

[chore]: rm deepmerge from peer deps#2124

Merged
seanmcguire12 merged 1 commit into
mainfrom
rm-deepmerge-from-deps
May 14, 2026
Merged

[chore]: rm deepmerge from peer deps#2124
seanmcguire12 merged 1 commit into
mainfrom
rm-deepmerge-from-deps

Conversation

@seanmcguire12
Copy link
Copy Markdown
Member

@seanmcguire12 seanmcguire12 commented May 14, 2026

why

  • unused peer dep

what changed

  • removed deepmerge from peer deps

Summary by cubic

Removed unused peer dependency deepmerge from packages/core. This simplifies installs and removes unnecessary peer warnings.

Written for commit 50652b8. Summary will update on new commits.

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 14, 2026

⚠️ No Changeset found

Latest commit: 50652b8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.
Architecture diagram
sequenceDiagram
    participant Consumer as Package Consumer
    participant PackageJson as package.json (core)
    participant NPM as npm Installer
    participant InstallScript as Install Script

    Note over Consumer,InstallScript: PR Impact: Removes deepmerge from peerDependencies

    Consumer->>PackageJson: Reads peerDependencies
    PackageJson-->>Consumer: List: patchright-core, playwright-core, puppeteer-core
    Note over Consumer,PackageJson: deepmerge no longer declared as peer dep

    Consumer->>NPM: npm install
    NPM->>PackageJson: Parse peerDependencies
    alt deepmerge NOT in peerDependencies
        NPM->>NPM: Skip warning about missing peer dep
        NPM-->>Consumer: Clean install, no extra peer dep conflict
    else deepmerge installed as transitive dep (optional)
        NPM->>NPM: No peer dep validation for deepmerge
        NPM-->>Consumer: Install proceeds normally
    end

    Note over Consumer,NPM: Result: Simpler dependency tree, fewer warnings

    Consumer->>InstallScript: run build/test
    InstallScript-->>Consumer: No deepmerge-related resolution failures
Loading

@seanmcguire12 seanmcguire12 merged commit f962245 into main May 14, 2026
214 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants